Reply to thread

Message

<blockquote data-quote="RyLe" data-source="post: 1150367" data-attributes="member: 377555">HiWith each kernel update from Fedora, I have to recompile the blindscan drivers.Going from 6.2.X to 6.3.X, I had to modify[ICODE]blindscan_kernel/media_build/v4l/Makefile[/ICODE]to add[ICODE]EXTRA_CFLAGS += -Wno-error=incompatible-pointer-types[/ICODE]otherwise there were blocking errors.It went ok for a few kernel updates.Now Fedora pushes the 6.4.4-200 and I have a new error when I try to compile the drivers (a matching kernel-devel is installed) :[ICODE]/home/ryle/blindscan_kernel/media_build/v4l/dvbdev.c: In function 'init_dvbdev':./include/linux/export.h:27:22: warning: passing argument 1 of 'class_create' from incompatible pointer type [-Wincompatible-pointer-types]&nbsp;&nbsp; 27 | #define THIS_MODULE (&amp;__this_module)&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; ~^~~~~~~~~~~~~~~&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; struct module */home/ryle/blindscan_kernel/media_build/v4l/dvbdev.c:1103:34: note: in expansion of macro 'THIS_MODULE'&nbsp;1103 |&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; dvb_class = class_create(THIS_MODULE, &quot;dvb&quot;);&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ^~~~~~~~~~~In file included from ./include/linux/device.h:31,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; from ./include/linux/input.h:19,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; from /home/ryle/blindscan_kernel/media_build/v4l/compat.h:47:./include/linux/device/class.h:230:54: note: expected 'const char *' but argument is of type 'struct module *'&nbsp; 230 | struct class * __must_check class_create(const char *name);&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ~~~~~~~~~~~~^~~~/home/ryle/blindscan_kernel/media_build/v4l/dvbdev.c:1103:21: error: too many arguments to function 'class_create'&nbsp;1103 |&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; dvb_class = class_create(THIS_MODULE, &quot;dvb&quot;);&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; ^~~~~~~~~~~~./include/linux/device/class.h:230:29: note: declared here&nbsp; 230 | struct class * __must_check class_create(const char *name);&nbsp; &nbsp; &nbsp; |&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; ^~~~~~~~~~~~make[3]: *** [scripts/Makefile.build:252: /home/ryle/blindscan_kernel/media_build/v4l/dvbdev.o] Error 1[/ICODE]If I simply try to patch it using <a href="https://github.com/esibun/LookingGlass/commit/22979967062113105af7356b51c655dc27ae2fa7" target="_blank">this technique</a>, I also have to modify[ICODE]/blindscan_kernel/media/drivers/media/pci/ddbridge/ddbridge-core.c[/ICODE] because of[ICODE].owner&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; = THIS_MODULE,[/ICODE] that doesn't exist in the class anymoreand then[ICODE]blindscan_kernel/media/drivers/media/pci/tbsmod/tbsmod.c[/ICODE] because of the same error listed for blindscan_kernel/media_build/v4l/dvbdev.cIt compiles, it installs, but it crashes when it loads as the modifications I made are probably stupid without reading what the rest of the code does.I could use some help <img src="https://www.satellites.co.uk/styles/default/xenforo/smilies/smile.png"&nbsp; class="smilie" loading="lazy" alt=":)" title="Smile&nbsp; &nbsp; :)" data-shortname=":)" />I'll revert to booting the previous kernel in the mean time.</blockquote>

[QUOTE="RyLe, post: 1150367, member: 377555"] Hi With each kernel update from Fedora, I have to recompile the blindscan drivers. Going from 6.2.X to 6.3.X, I had to modify [ICODE]blindscan_kernel/media_build/v4l/Makefile[/ICODE] to add [ICODE]EXTRA_CFLAGS += -Wno-error=incompatible-pointer-types[/ICODE] otherwise there were blocking errors. It went ok for a few kernel updates. Now Fedora pushes the 6.4.4-200 and I have a new error when I try to compile the drivers (a matching kernel-devel is installed) : [ICODE] /home/ryle/blindscan_kernel/media_build/v4l/dvbdev.c: In function 'init_dvbdev': ./include/linux/export.h:27:22: warning: passing argument 1 of 'class_create' from incompatible pointer type [-Wincompatible-pointer-types] 27 | #define THIS_MODULE (&__this_module) | ~^~~~~~~~~~~~~~~ | | | struct module * /home/ryle/blindscan_kernel/media_build/v4l/dvbdev.c:1103:34: note: in expansion of macro 'THIS_MODULE' 1103 | dvb_class = class_create(THIS_MODULE, "dvb"); | ^~~~~~~~~~~ In file included from ./include/linux/device.h:31, from ./include/linux/input.h:19, from /home/ryle/blindscan_kernel/media_build/v4l/compat.h:47: ./include/linux/device/class.h:230:54: note: expected 'const char *' but argument is of type 'struct module *' 230 | struct class * __must_check class_create(const char *name); | ~~~~~~~~~~~~^~~~ /home/ryle/blindscan_kernel/media_build/v4l/dvbdev.c:1103:21: error: too many arguments to function 'class_create' 1103 | dvb_class = class_create(THIS_MODULE, "dvb"); | ^~~~~~~~~~~~ ./include/linux/device/class.h:230:29: note: declared here 230 | struct class * __must_check class_create(const char *name); | ^~~~~~~~~~~~ make[3]: *** [scripts/Makefile.build:252: /home/ryle/blindscan_kernel/media_build/v4l/dvbdev.o] Error 1 [/ICODE] If I simply try to patch it using [URL='https://github.com/esibun/LookingGlass/commit/22979967062113105af7356b51c655dc27ae2fa7']this technique[/URL], I also have to modify [ICODE]/blindscan_kernel/media/drivers/media/pci/ddbridge/ddbridge-core.c[/ICODE] because of [ICODE].owner = THIS_MODULE,[/ICODE] that doesn't exist in the class anymore and then [ICODE]blindscan_kernel/media/drivers/media/pci/tbsmod/tbsmod.c[/ICODE] because of the same error listed for blindscan_kernel/media_build/v4l/dvbdev.c It compiles, it installs, but it crashes when it loads as the modifications I made are probably stupid without reading what the rest of the code does. I could use some help :) I'll revert to booting the previous kernel in the mean time. [/QUOTE]

Verification